Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: registry proxy #9722

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat: registry proxy #9722

merged 1 commit into from
Nov 21, 2024

Conversation

DmitriyMV
Copy link
Member

@DmitriyMV DmitriyMV commented Nov 14, 2024 •
edited
Loading

Implement container registry proxy.

@DmitriyMV DmitriyMV force-pushed the registry-proxy branch 3 times, most recently from acb3f33 to 4bee044 Compare November 14, 2024 10:35
smira
smira reviewed Nov 14, 2024
View reviewed changes
hack/cri-plugin.part Outdated Show resolved Hide resolved
@DmitriyMV DmitriyMV marked this pull request as ready for review November 19, 2024 18:43
@DmitriyMV
Copy link
Member Author

It's finally working. To test you have to run it with --registry-mirror ghcr.io=http://127.0.0.1:3172 and --registry-mirror gcr.io=http://127.0.0.1:3172. Dockerfile should do the rest.
yay

@DmitriyMV DmitriyMV force-pushed the registry-proxy branch 2 times, most recently from 710172b to 38f321f Compare November 19, 2024 19:18
@dsseng dsseng mentioned this pull request Nov 19, 2024
Merged
DmitriyMV
DmitriyMV commented Nov 21, 2024
View reviewed changes
internal/app/machined/pkg/system/services/registryd.go
func (r *registryD) Condition(runtime.Runtime) conditions.Condition { return nil }
func (r *registryD) DependsOn(runtime.Runtime) []string { return nil }

func (r *registryD) HealthFunc(runtime.Runtime) health.Check {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smira healthcheck ^^^

@DmitriyMV
feat: registry proxy
0ffb218 
Implement container registry proxy.

Signed-off-by: Dmitriy Matrenichev <[email protected]>
@DmitriyMV
Copy link
Member Author

/m

@talos-bot talos-bot merged commit 0ffb218 into siderolabs:main Nov 21, 2024
50 checks passed
@DmitriyMV DmitriyMV deleted the registry-proxy branch November 21, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frezbo frezbo frezbo approved these changes

@smira smira smira approved these changes

@dsseng dsseng dsseng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DmitriyMV @smira @frezbo @dsseng @talos-bot